Files
gerbeur/api/test/dumps.test.ts
khannurien de5abeceb2
All checks were successful
Build and Publish Docker Image / build-and-push (push) Successful in 49s
v3: a performance pass over both halves — indexed queries, streamed files, cached previews, and feeds that stop re-rendering on every tick — a review turned up whole-file reads, unindexed scans and render storms; each fix comes with a test. Database: migration 0016 adds the indexes the hot queries lacked — dumps by created_at, (user_id, created_at) and slug, votes by (user_id, created_at), playlists by slug, users by lower(username) for @mentions, and the child side of every cascading foreign key (comment replies, a user's comments, follows both ways, chat messages, invites, reset tokens); the feeds, dump and playlist pages, upvotes and follower fan-out all plan as index searches now, with no temp-table sort. SQLite runs in WAL with synchronous=NORMAL and a busy timeout, and a transaction() helper wraps the multi-row writes (a dump and its categories, category sets, backlinks, attachment links, playlist reorders, follower notifications) so they commit once instead of once a row. Lists no longer run a COUNT(*) per page: they fetch limit + 1 rows and hasMore comes from the extra one; total stays only on search, the one place it's shown. Files: /api/files read the whole upload (up to 50 MB) for every range request a player makes while seeking; api/lib/serve-file.ts streams the requested bytes from disk, with an ETag and 304s, and serves avatars, attachments, covers and thumbnails too. File and thumbnail URLs carry the file's version (size and last change), so the current one is cached for a year and anything else revalidates — a same-size replacement used to stay stale, and a video's still was cached immutable forever under a URL that never changed. Feeds showed image dumps at full size: /api/thumbnails now makes a 960px preview with ffmpeg (GIFs and unreadable images go out as they are), one run per output however many cards ask at once, and ffmpeg is probed once per process instead of spawned per request. Uploads stream to disk; replacing a file writes beside it and renames over, a hard link keeping the old one for rollback instead of holding both in memory; generated stills and previews go when the file is replaced or the dump deleted, and a custom thumbnail with its dump. Outbound: fetchWithTimeout's deadline now covers the body — a server that answered at once and then dripped could hold a create open indefinitely — and pages are read to 4 MB at most; metadata is cached five minutes so the create form's preview and the post that follows share one fetch (refresh-metadata still goes to the page); proxied images sit in a 32 MB LRU. Broadcasts serialize once rather than per socket, and index.html is kept in memory until the file changes. Frontend: currentTime lived in PlayerContext, so every card re-rendered — and re-parsed its Markdown — four times a second while anything played; the playhead has its own PlayerTimeContext now. The socket context is split three ways (feed, chat via useWSChat, presence via useWSPresence), so typing, presence and chat messages leave the feeds alone. DumpCard, JournalCard and Markdown are memoized; card images use the server preview and load lazily; the feed cache is written when the page is left rather than after every pause in scrolling; the theme context value is memoized.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-27 16:35:51 +00:00

798 lines
26 KiB
TypeScript

import {
count,
createUser,
db,
del,
formWithFile,
get,
html,
insertCategory,
insertComment,
insertDump,
insertPlaylist,
PNG,
post,
put,
stubNetwork,
test,
TEST_DIR,
} from "./helpers.ts";
import type {
Dump,
DumpUrlMatch,
PaginatedData,
Playlist,
PublicUser,
} from "../model/interfaces.ts";
import {
assert,
assertEquals,
assertExists,
assertFalse,
assertMatch,
assertNotEquals,
} from "@std/assert";
const PAGE = html(`<title>Scraped title</title>
<meta property="og:image" content="https://example.com/cover.jpg">`);
function readFile(path: string): Uint8Array | null {
try {
return Deno.readFileSync(`${TEST_DIR}/uploads/${path}`);
} catch {
return null;
}
}
// ── Create ───────────────────────────────────────────────────────────────────
test("POST /api/dumps: a URL dump takes its title from the page", async () => {
const user = await createUser();
using _ = stubNetwork(() => PAGE.clone());
const res = await post<Dump>("/api/dumps", {
auth: user.auth,
json: { url: "https://example.com/a?utm_source=x", comment: "look" },
});
assertEquals(res.status, 201);
const dump = res.data;
assertEquals(dump.kind, "url");
assertEquals(dump.title, "Scraped title");
assertMatch(dump.slug ?? "", /^scraped-title-[0-9a-f]{8}$/);
assertEquals(dump.userId, user.id);
assertEquals(dump.isPrivate, false);
assertEquals(dump.richContent?.thumbnailUrl, "https://example.com/cover.jpg");
const row = db.prepare(`SELECT url, url_canonical FROM dumps WHERE id = ?;`)
.get(dump.id) as { url: string; url_canonical: string };
// The exact URL is kept; the canonical key drops the tracking parameter.
assertEquals(row.url, "https://example.com/a?utm_source=x");
assertEquals(row.url_canonical, "https://example.com/a");
});
test("POST /api/dumps: a typed title wins; an unreachable page still posts", async () => {
const user = await createUser();
{
using _ = stubNetwork(() => PAGE.clone());
const res = await post<Dump>("/api/dumps", {
auth: user.auth,
json: { url: "https://example.com/b", title: " My title " },
});
assertEquals(res.data.title, "My title");
}
{
using _ = stubNetwork(() => {
throw new TypeError("offline");
});
const res = await post<Dump>("/api/dumps", {
auth: user.auth,
json: { url: "https://www.offline.example/c" },
});
assertEquals(res.status, 201);
assertEquals(res.data.title, "offline.example");
}
});
test("POST /api/dumps: refuses bad URLs and bodies, and anonymous callers", async () => {
const user = await createUser();
using net = stubNetwork(() => PAGE.clone());
for (
const url of ["http://localhost/", "http://192.168.0.1/", "ftp://x/", "no"]
) {
const res = await post("/api/dumps", { auth: user.auth, json: { url } });
assertEquals(res.status, 400, url);
}
assertEquals(
(await post("/api/dumps", { auth: user.auth, json: { nope: 1 } })).status,
400,
);
assertEquals(
(await post("/api/dumps", { json: { url: "https://example.com" } })).status,
401,
);
assertEquals(net.calls.length, 0);
assertEquals(count(`SELECT COUNT(*) as n FROM dumps;`), 0);
});
test("POST /api/dumps: categories are stored and deduplicated", async () => {
const user = await createUser();
const music = insertCategory({ slug: "music" });
using _ = stubNetwork(() => PAGE.clone());
const res = await post<Dump>("/api/dumps", {
auth: user.auth,
json: { url: "https://example.com/d", categoryIds: [music, music] },
});
assertEquals(res.status, 201);
assertEquals(res.data.categoryIds, [music]);
assertEquals(
(await get<Dump>(`/api/dumps/${res.data.id}`)).data.categoryIds,
[music],
);
});
test("POST /api/dumps: an unknown category is refused and nothing is left behind", async () => {
const user = await createUser();
using _ = stubNetwork(() => PAGE.clone());
const res = await post("/api/dumps", {
auth: user.auth,
json: { url: "https://example.com/e", categoryIds: ["no-such-category"] },
});
assertEquals(res.status, 400);
assertEquals(count(`SELECT COUNT(*) as n FROM dumps;`), 0);
});
test("POST /api/dumps: a file dump is stored and served back", async () => {
const user = await createUser();
const res = await post<Dump>("/api/dumps", {
auth: user.auth,
form: formWithFile(PNG, "pixel.png", "image/png", { comment: "tiny" }),
});
assertEquals(res.status, 201);
const dump = res.data;
assertEquals(dump.kind, "file");
assertEquals(dump.title, "pixel.png");
assertEquals(dump.fileMime, "image/png");
assertEquals(dump.fileSize, PNG.byteLength);
assertEquals(dump.comment, "tiny");
assertEquals(readFile(`dumps/${dump.id}`), PNG);
const file = await get(`/api/files/${dump.id}`);
assertEquals(file.status, 200);
assertEquals(file.bytes, PNG);
});
test("POST /api/dumps: file type, size of text fields, and a missing file", async () => {
const user = await createUser();
const exe = await post("/api/dumps", {
auth: user.auth,
form: formWithFile(PNG, "x.exe", "application/x-msdownload"),
});
assertEquals(exe.status, 400);
const longTitle = await post("/api/dumps", {
auth: user.auth,
form: formWithFile(PNG, "x.png", "image/png", { title: "x".repeat(201) }),
});
assertEquals(longTitle.status, 400);
const longComment = await post("/api/dumps", {
auth: user.auth,
form: formWithFile(PNG, "x.png", "image/png", {
comment: "x".repeat(5001),
}),
});
assertEquals(longComment.status, 400);
const form = new FormData();
form.set("comment", "no file");
assertEquals(
(await post("/api/dumps", { auth: user.auth, form })).status,
400,
);
assertEquals(count(`SELECT COUNT(*) as n FROM dumps;`), 0);
});
test("POST /api/dumps: a file dump with an unknown category leaves nothing behind", async () => {
const user = await createUser();
const res = await post("/api/dumps", {
auth: user.auth,
form: formWithFile(PNG, "x.png", "image/png", {
categoryIds: JSON.stringify(["nope"]),
}),
});
assertEquals(res.status, 400);
assertEquals(count(`SELECT COUNT(*) as n FROM dumps;`), 0);
});
test("POST /api/dumps: followers are notified of public dumps, not private ones", async () => {
const poster = await createUser();
const follower = await createUser();
db.prepare(
`INSERT INTO follows (id, follower_id, followed_user_id, created_at) VALUES (?, ?, ?, ?);`,
).run(crypto.randomUUID(), follower.id, poster.id, new Date().toISOString());
using _ = stubNetwork(() => PAGE.clone());
await post("/api/dumps", {
auth: poster.auth,
json: { url: "https://example.com/private", isPrivate: true },
});
assertEquals(count(`SELECT COUNT(*) as n FROM notifications;`), 0);
const pub = await post<Dump>("/api/dumps", {
auth: poster.auth,
json: { url: "https://example.com/public" },
});
const notes = db.prepare(
`SELECT user_id, type, data FROM notifications;`,
).all() as { user_id: string; type: string; data: string }[];
assertEquals(notes.length, 1);
assertEquals(notes[0].user_id, follower.id);
assertEquals(notes[0].type, "user_dump_posted");
assertEquals(JSON.parse(notes[0].data).dumpId, pub.data.id);
});
// ── Read ─────────────────────────────────────────────────────────────────────
test("GET /api/dumps/:id works by id and by slug", async () => {
const user = await createUser();
const { id, slug } = insertDump({ userId: user.id, title: "Hello" });
assertEquals((await get<Dump>(`/api/dumps/${id}`)).data.id, id);
assertEquals((await get<Dump>(`/api/dumps/${slug}`)).data.id, id);
assertEquals((await get(`/api/dumps/nope`)).status, 404);
assertEquals((await get(`/api/dumps/${crypto.randomUUID()}`)).status, 404);
});
test("GET /api/dumps/:id: a private dump exists only for its owner", async () => {
const owner = await createUser();
const other = await createUser();
const { id } = insertDump({ userId: owner.id, isPrivate: true });
assertEquals(
(await get(`/api/dumps/${id}`, { auth: owner.auth })).status,
200,
);
assertEquals(
(await get(`/api/dumps/${id}`, { auth: other.auth })).status,
404,
);
assertEquals((await get(`/api/dumps/${id}`)).status, 404);
for (const sub of ["voters", "related", "playlists", "comments"]) {
assertEquals((await get(`/api/dumps/${id}/${sub}`)).status, 404, sub);
assertEquals(
(await get(`/api/dumps/${id}/${sub}`, { auth: owner.auth })).status,
200,
sub,
);
}
});
test("GET /api/dumps: newest first, paginated, private ones for the owner only", async () => {
const owner = await createUser();
const other = await createUser();
for (let i = 0; i < 5; i++) {
insertDump({
userId: owner.id,
title: `d${i}`,
createdAt: new Date(Date.UTC(2024, 0, i + 1)).toISOString(),
});
}
insertDump({
userId: owner.id,
title: "secret",
isPrivate: true,
createdAt: new Date(Date.UTC(2024, 0, 10)).toISOString(),
});
const page1 = await get<PaginatedData<Dump>>("/api/dumps?limit=2");
assertEquals(page1.data.items.map((d) => d.title), [
"d4",
"d3",
]);
assertEquals(page1.data.hasMore, true);
// Pages are told apart by the row past the limit, not by a count.
assertEquals(page1.data.total, undefined);
const page3 = await get<PaginatedData<Dump>>("/api/dumps?limit=2&page=3");
assertEquals(page3.data.items.length, 1);
assertEquals(page3.data.hasMore, false);
const mine = await get<PaginatedData<Dump>>("/api/dumps", {
auth: owner.auth,
});
assertEquals(mine.data.items[0].title, "secret");
assertEquals(mine.data.items.length, 6);
assertEquals(
(await get<PaginatedData<Dump>>("/api/dumps", { auth: other.auth })).data
.items.length,
5,
);
});
test("GET /api/dumps/by-url: matches on the canonical key, respects privacy", async () => {
const owner = await createUser();
const other = await createUser();
insertDump({
userId: owner.id,
title: "public",
url: "https://youtu.be/abc",
});
insertDump({
userId: owner.id,
title: "private",
url: "https://www.youtube.com/watch?v=abc",
isPrivate: true,
});
const q = encodeURIComponent("https://m.youtube.com/watch?v=abc&t=10");
const anon = await get<DumpUrlMatch[]>(`/api/dumps/by-url?url=${q}`);
assertEquals(anon.data.map((d) => d.title), [
"public",
]);
assertEquals(anon.data[0].username, owner.username);
const mine = await get<DumpUrlMatch[]>(`/api/dumps/by-url?url=${q}`, {
auth: owner.auth,
});
assertEquals(mine.data.length, 2);
assertEquals(
(await get<DumpUrlMatch[]>(`/api/dumps/by-url?url=${q}`, {
auth: other.auth,
})).data
.length,
1,
);
assertEquals(
(await get<DumpUrlMatch[]>(`/api/dumps/by-url?url=garbage`)).data,
[],
);
});
test("GET /api/dumps/:id/voters lists voters without private fields", async () => {
const owner = await createUser();
const voter = await createUser();
const { id } = insertDump({ userId: owner.id });
db.prepare(
`INSERT INTO votes (dump_id, user_id, created_at) VALUES (?, ?, ?);`,
).run(id, voter.id, new Date().toISOString());
const res = await get<PaginatedData<PublicUser>>(`/api/dumps/${id}/voters`);
assertEquals(res.data.items.length, 1);
assertEquals(res.data.items[0].username, voter.username);
assertFalse("email" in res.data.items[0]);
assertFalse("passwordHash" in res.data.items[0]);
});
test("GET /api/dumps/:id/related: links in both directions, hiding private ones", async () => {
const user = await createUser();
const other = await createUser();
const target = insertDump({
userId: user.id,
title: "target",
url: "https://x.test/t",
});
const secret = insertDump({
userId: other.id,
title: "secret",
isPrivate: true,
});
using _ = stubNetwork(() => PAGE.clone());
// A new dump whose comment links the target by its URL and the secret dump by
// its page — and itself, which is ignored.
const src = await post<Dump>("/api/dumps", {
auth: other.auth,
json: {
url: "https://example.com/src",
comment:
`see https://x.test/t and http://anywhere/dumps/${secret.slug} and http://gerbeur.test/dumps/self`,
},
});
const srcId = src.data.id;
const fromSrc = await get<Dump[]>(`/api/dumps/${srcId}/related`);
assertEquals(fromSrc.data.map((d) => d.title), [
"target",
]);
const fromSrcAsOwner = await get<Dump[]>(`/api/dumps/${srcId}/related`, {
auth: other.auth,
});
assertEquals(fromSrcAsOwner.data.length, 2);
const toTarget = await get<Dump[]>(`/api/dumps/${target.id}/related`);
assertEquals(toTarget.data.map((d) => d.id), [srcId]);
// Editing the comment away removes the links.
await put(`/api/dumps/${srcId}`, { auth: other.auth, json: { comment: "" } });
assertEquals((await get<Dump[]>(`/api/dumps/${target.id}/related`)).data, []);
});
test("GET /api/dumps/:id/playlists: public playlists, plus the viewer's private ones", async () => {
const user = await createUser();
const other = await createUser();
const { id } = insertDump({ userId: user.id });
const pub = insertPlaylist({ userId: user.id, title: "Public" });
const priv = insertPlaylist({
userId: user.id,
title: "Private",
isPublic: false,
});
for (const p of [pub, priv]) {
db.prepare(
`INSERT INTO playlist_dumps (playlist_id, dump_id, position, added_at) VALUES (?, ?, 0, ?);`,
).run(p.id, id, new Date().toISOString());
}
assertEquals(
(await get<Playlist[]>(`/api/dumps/${id}/playlists`, { auth: other.auth }))
.data
.map((p) => p.title),
["Public"],
);
assertEquals(
(await get<Playlist[]>(`/api/dumps/${id}/playlists`, { auth: user.auth }))
.data
.length,
2,
);
});
// ── Update ───────────────────────────────────────────────────────────────────
test("PUT /api/dumps/:id: owner and moderator may edit, others may not", async () => {
const owner = await createUser();
const other = await createUser();
const mod = await createUser({ role: "moderator" });
const { id, slug } = insertDump({ userId: owner.id, title: "Old" });
assertEquals(
(await put(`/api/dumps/${id}`, { auth: other.auth, json: { title: "X" } }))
.status,
403,
);
assertEquals(
(await put(`/api/dumps/${id}`, { json: { title: "X" } })).status,
401,
);
const res = await put<Dump>(`/api/dumps/${slug}`, {
auth: owner.auth,
json: { title: "New title", comment: "hello" },
});
assertEquals(res.status, 200);
assertEquals(res.data.title, "New title");
assertMatch(res.data.slug ?? "", /^new-title-/);
assertNotEquals(res.data.slug, slug);
assertExists(res.data.updatedAt);
const byMod = await put(`/api/dumps/${id}`, {
auth: mod.auth,
json: { title: "Moderated" },
});
assertEquals(byMod.status, 200);
assertEquals((await get<Dump>(`/api/dumps/${id}`)).data.title, "Moderated");
});
test("PUT /api/dumps/:id: invalid input is 422, a new URL refetches metadata", async () => {
const owner = await createUser();
const { id } = insertDump({
userId: owner.id,
title: "Old",
url: "https://a.test/",
});
assertEquals(
(await put(`/api/dumps/${id}`, { auth: owner.auth, json: { title: " " } }))
.status,
422,
);
assertEquals(
(await put(`/api/dumps/${id}`, {
auth: owner.auth,
json: { url: "http://127.0.0.1/" },
})).status,
400,
);
using net = stubNetwork(() => PAGE.clone());
// Same URL: no fetch, title kept.
await put(`/api/dumps/${id}`, { auth: owner.auth, json: { comment: "c" } });
assertEquals(net.calls.length, 0);
const moved = await put<Dump>(`/api/dumps/${id}`, {
auth: owner.auth,
json: { url: "https://b.test/?utm_medium=z" },
});
assertEquals(moved.data.title, "Scraped title");
assertEquals(net.calls.length, 1);
const row = db.prepare(`SELECT url_canonical FROM dumps WHERE id = ?;`).get(
id,
) as {
url_canonical: string;
};
assertEquals(row.url_canonical, "https://b.test");
});
test("PUT /api/dumps/:id: categories are replaced, or kept when omitted", async () => {
const owner = await createUser();
const a = insertCategory({ slug: "a" });
const b = insertCategory({ slug: "b" });
const { id } = insertDump({ userId: owner.id });
await put(`/api/dumps/${id}`, {
auth: owner.auth,
json: { categoryIds: [a] },
});
const kept = await put<Dump>(`/api/dumps/${id}`, {
auth: owner.auth,
json: { title: "t" },
});
assertEquals(kept.data.categoryIds, [a]);
const replaced = await put<Dump>(`/api/dumps/${id}`, {
auth: owner.auth,
json: { categoryIds: [b] },
});
assertEquals(replaced.data.categoryIds, [b]);
const cleared = await put<Dump>(`/api/dumps/${id}`, {
auth: owner.auth,
json: { categoryIds: [] },
});
assertEquals(cleared.data.categoryIds, []);
});
test("PUT /api/dumps/:id: an unknown category changes nothing", async () => {
const owner = await createUser();
const a = insertCategory({ slug: "a" });
const { id } = insertDump({ userId: owner.id, title: "Before" });
await put(`/api/dumps/${id}`, {
auth: owner.auth,
json: { categoryIds: [a] },
});
const res = await put(`/api/dumps/${id}`, {
auth: owner.auth,
json: { title: "After", categoryIds: [a, "nope"] },
});
assertEquals(res.status, 400);
const dump = (await get<Dump>(`/api/dumps/${id}`)).data;
assertEquals(dump.title, "Before");
assertEquals(dump.categoryIds, [a]);
});
test("PUT /api/dumps/:id/file: an unknown category keeps the old file", async () => {
const owner = await createUser();
const original = new TextEncoder().encode("original");
const { id } = insertDump({
userId: owner.id,
title: "orig",
fileName: "a.txt",
fileData: original,
});
const res = await put(`/api/dumps/${id}/file`, {
auth: owner.auth,
form: formWithFile(PNG, "b.png", "image/png", {
categoryIds: JSON.stringify(["nope"]),
}),
});
assertEquals(res.status, 400);
assertEquals(readFile(`dumps/${id}`), original);
assertEquals((await get<Dump>(`/api/dumps/${id}`)).data.fileName, "a.txt");
});
test("PUT /api/dumps/:id: going private hides the dump from everyone else", async () => {
const owner = await createUser();
const { id } = insertDump({ userId: owner.id });
await put(`/api/dumps/${id}`, {
auth: owner.auth,
json: { isPrivate: true },
});
assertEquals((await get(`/api/dumps/${id}`)).status, 404);
await put(`/api/dumps/${id}`, {
auth: owner.auth,
json: { isPrivate: false },
});
assertEquals((await get(`/api/dumps/${id}`)).status, 200);
});
test("PUT /api/dumps/:id: a file dump edits title, comment and privacy", async () => {
const owner = await createUser();
const { id } = insertDump({
userId: owner.id,
title: "file",
fileName: "a.txt",
});
const res = await put<Dump>(`/api/dumps/${id}`, {
auth: owner.auth,
json: {
title: "Renamed",
comment: "c",
isPrivate: true,
url: "https://ignored.test",
},
});
assertEquals(res.status, 200);
assertEquals(res.data.title, "Renamed");
assertEquals(res.data.isPrivate, true);
assertEquals(res.data.url, undefined);
});
test("PUT /api/dumps/:id/file replaces a file dump's contents", async () => {
const owner = await createUser();
const other = await createUser();
const { id } = insertDump({
userId: owner.id,
title: "orig",
fileName: "a.txt",
});
const form = () =>
formWithFile(PNG, "b.png", "image/png", { title: "Replaced" });
assertEquals(
(await put(`/api/dumps/${id}/file`, { auth: other.auth, form: form() }))
.status,
403,
);
const res = await put<Dump>(`/api/dumps/${id}/file`, {
auth: owner.auth,
form: form(),
});
assertEquals(res.status, 200);
assertEquals(res.data.fileName, "b.png");
assertEquals(res.data.title, "Replaced");
assertEquals(readFile(`dumps/${id}`), PNG);
const urlDump = insertDump({ userId: owner.id });
assertEquals(
(await put(`/api/dumps/${urlDump.id}/file`, {
auth: owner.auth,
form: form(),
}))
.status,
400,
);
});
test("PUT /api/dumps/:id/file: visibility changes with the file, or stays", async () => {
const owner = await createUser();
const other = await createUser();
const { id } = insertDump({ userId: owner.id, fileName: "a.txt" });
const replace = (fields: Record<string, string>) =>
put<Dump>(`/api/dumps/${id}/file`, {
auth: owner.auth,
form: formWithFile(PNG, "b.png", "image/png", fields),
});
const visible = async () =>
(await get(`/api/dumps/${id}`, { auth: other.auth })).status === 200;
let res = await replace({ isPrivate: "true" });
assertEquals(res.data.isPrivate, true);
assertEquals(await visible(), false);
assertEquals((await get(`/api/files/${id}`)).status, 404);
// Left out, it stays private.
res = await replace({});
assertEquals(res.data.isPrivate, true);
assertEquals(await visible(), false);
res = await replace({ isPrivate: "false" });
assertEquals(res.data.isPrivate, false);
assertEquals(await visible(), true);
// A refused replacement changes neither.
res = await replace({ isPrivate: "true", categoryIds: '["nope"]' });
assertEquals(res.status, 400);
assertEquals(await visible(), true);
});
test("custom thumbnails: set, served, removed", async () => {
const owner = await createUser();
const other = await createUser();
const { id } = insertDump({ userId: owner.id });
assertEquals(
(await put(`/api/dumps/${id}/thumbnail`, {
auth: other.auth,
form: formWithFile(PNG),
})).status,
403,
);
assertEquals(
(await put(`/api/dumps/${id}/thumbnail`, {
auth: owner.auth,
form: formWithFile(
new TextEncoder().encode("<svg/>"),
"x.svg",
"image/svg+xml",
),
})).status,
400,
);
const set = await put<Dump>(`/api/dumps/${id}/thumbnail`, {
auth: owner.auth,
form: formWithFile(PNG),
});
assertEquals(set.status, 200);
assertEquals(set.data.thumbnailMime, "image/png");
const thumb = await get(`/api/thumbnails/${id}`);
assertEquals(thumb.status, 200);
assertEquals(thumb.headers.get("content-type"), "image/png");
assertEquals(thumb.bytes, PNG);
const removed = await del<Dump>(`/api/dumps/${id}/thumbnail`, {
auth: owner.auth,
});
assertEquals(removed.data.thumbnailMime, undefined);
assertEquals(readFile(`thumbnails/${id}-custom`), null);
// A URL dump without its own thumbnail has none to serve.
assertEquals((await get(`/api/thumbnails/${id}`)).status, 404);
});
test("POST /api/dumps/:id/refresh-metadata: updates, or keeps what it had on failure", async () => {
const owner = await createUser();
const { id } = insertDump({
userId: owner.id,
title: "Kept",
url: "https://example.com/r",
richContent: {
type: "generic",
url: "https://example.com/r",
title: "Kept",
},
});
{
using _ = stubNetwork(() => {
throw new TypeError("down");
});
const res = await post<Dump>(`/api/dumps/${id}/refresh-metadata`, {
auth: owner.auth,
});
assertEquals(res.status, 502);
assertEquals((await get<Dump>(`/api/dumps/${id}`)).data.title, "Kept");
}
{
using _ = stubNetwork(() => PAGE.clone());
const res = await post<Dump>(`/api/dumps/${id}/refresh-metadata`, {
auth: owner.auth,
});
assertEquals(res.status, 200);
assertEquals(res.data.title, "Scraped title");
}
const file = insertDump({ userId: owner.id, fileName: "f.txt" });
assertEquals(
(await post(`/api/dumps/${file.id}/refresh-metadata`, { auth: owner.auth }))
.status,
400,
);
});
// ── Delete ───────────────────────────────────────────────────────────────────
test("DELETE /api/dumps/:id removes the dump, its file and what hangs off it", async () => {
const owner = await createUser();
const other = await createUser();
const mod = await createUser({ role: "moderator" });
const { id } = insertDump({ userId: owner.id, fileName: "f.txt" });
insertComment({ dumpId: id, userId: other.id });
db.prepare(
`INSERT INTO votes (dump_id, user_id, created_at) VALUES (?, ?, ?);`,
)
.run(id, other.id, new Date().toISOString());
assertEquals(
(await del(`/api/dumps/${id}`, { auth: other.auth })).status,
403,
);
assertEquals(
(await del(`/api/dumps/${id}`, { auth: owner.auth })).status,
200,
);
assertEquals((await get(`/api/dumps/${id}`)).status, 404);
assertEquals(readFile(`dumps/${id}`), null);
assertEquals(count(`SELECT COUNT(*) as n FROM comments;`), 0);
assertEquals(count(`SELECT COUNT(*) as n FROM votes;`), 0);
const second = insertDump({ userId: owner.id });
assertEquals(
(await del(`/api/dumps/${second.id}`, { auth: mod.auth })).status,
200,
);
assertEquals(
(await del(`/api/dumps/${second.id}`, { auth: mod.auth })).status,
404,
);
});
test("GET /api/users/:username/dumps and /votes respect privacy", async () => {
const owner = await createUser();
const other = await createUser();
const pub = insertDump({ userId: owner.id, title: "pub" });
const priv = insertDump({ userId: owner.id, title: "priv", isPrivate: true });
for (const d of [pub, priv]) {
db.prepare(
`INSERT INTO votes (dump_id, user_id, created_at) VALUES (?, ?, ?);`,
)
.run(d.id, owner.id, new Date().toISOString());
}
for (const sub of ["dumps", "votes"]) {
const path = `/api/users/${owner.username}/${sub}`;
const total = async (opts?: { auth: { Authorization: string } }) =>
(await get<PaginatedData<Dump>>(path, opts)).data.items.length;
assertEquals(await total(), 1, sub);
assertEquals(await total({ auth: other.auth }), 1, sub);
assertEquals(
await total({ auth: owner.auth }),
2,
sub,
);
}
assert((await get(`/api/users/nobody_at_all/dumps`)).status === 404);
});