Files
gerbeur/api/test/services/rich-content-service.test.ts
khannurien 2c3ba6ad11 v4: link previews are read once, in one place, and no longer take an error page, a relative image or a mask icon for the page's — each provider fetched its page and scanned it with regular expressions of its own, the generic one some fifteen times, and Bandcamp and SoundCloud read only OG tags. fetchPage (remote/fetch.ts) now fetches every page, follows redirects to the address it was served from, and refuses an error status, so a 404 or a bot challenge is unreachable rather than a preview titled "Just a moment...", and a refresh no longer overwrites good metadata with it. parsePage (remote/html.ts) reads it in one linear pass with a real attribute reader: unquoted values, a > inside quotes, og: tags under name as well as property, and nothing from comments or scripts. Every URL a page names is resolved against where it was served from, so a relative og:image works; entities are decoded in one pass, &eacute; and &rsquo; included, and one that names no character no longer fails the preview (bandcamp-tralbum.ts shares the decoder). The mask icon is no longer the favicon, JSON-LD prefers the page's node over the site's, tracking pixels and lazy placeholders aren't thumbnails, an og:url with a slug keeps the OG tags, and a <title> loses its site suffix. genericPreview is the base of the Bandcamp, SoundCloud and YouTube channel previews; SoundCloud takes www., m. and on.soundcloud.com short links, embedding the page they lead to, and Bandcamp keeps only its own player. The service tidies every preview: text on one line, titles and descriptions capped, only http(s) images and players. RichContent.type is now RichContentType, and the unused videoId is gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-09 20:46:32 +00:00

56 lines
2.0 KiB
TypeScript

import { html, stubNetwork } from "../helpers.ts";
import { assert, assertEquals, assertFalse } from "@std/assert";
import { tryFetchRichContent } from "../../services/rich-content-service.ts";
Deno.test("tryFetchRichContent: a preview and the post that follows share one fetch", async () => {
using net = stubNetwork(() => html(`<title>Once</title>`));
const first = await tryFetchRichContent("https://example.com/once");
const second = await tryFetchRichContent("https://example.com/once");
assertEquals(second, first);
assertEquals(net.calls.length, 1);
// A refresh always goes to the page.
await tryFetchRichContent("https://example.com/once", { fresh: true });
assertEquals(net.calls.length, 2);
});
Deno.test("tryFetchRichContent: failures aren't kept", async () => {
let up = false;
using net = stubNetwork(() => {
if (!up) throw new TypeError("connection refused");
return html(`<title>Up</title>`);
});
const url = "https://example.com/flaky";
assertFalse((await tryFetchRichContent(url)).ok);
up = true;
const { ok, content } = await tryFetchRichContent(url);
assert(ok);
assertEquals(content?.title, "Up");
assertEquals(net.calls.length, 2);
});
Deno.test("tryFetchRichContent: an unreachable page is ok:false with a stub", async () => {
using _ = stubNetwork(() => {
throw new TypeError("connection refused");
});
assertEquals(await tryFetchRichContent("https://www.example.com/x"), {
ok: false,
content: {
type: "generic",
url: "https://www.example.com/x",
siteName: "example.com",
},
});
});
Deno.test("tryFetchRichContent: an error page is unreachable, not a preview", async () => {
using net = stubNetwork(() => html(`<title>404 Not Found</title>`, 404));
const url = "https://example.com/gone";
assertEquals(await tryFetchRichContent(url), {
ok: false,
content: { type: "generic", url, siteName: "example.com" },
});
// Not kept: the page may be back next time.
await tryFetchRichContent(url);
assertEquals(net.calls.length, 2);
});