Files
gerbeur/shared/notification.ts
khannurien 0d4e344d77 v3: comments say what the code can't — the documentation pass wanted JSDoc on every export and every field of an exported interface, which filled the code with restatements ("The dump.", "Whether it is loading.", "The props of X.", "Renders the X.") and module docs that told a reader nothing ("The hot and new feeds, and the props every main feed of the index takes."); some were wrong as well as vague. Every comment in api/, shared/ and src/ is rewritten under one rule, now stated in the README's "Comments" section: every module and export still has a JSDoc, and it gives context (who uses it and where), usage (what a caller must know: a precondition, what it leaves to the caller, a side effect) or its place in the chain (where its input comes from, where its output goes); a field, parameter, private function or local gets one only when it adds to its parent's, and context about a whole type goes on the type; a type's doc is phrased from the value's side ("Returned to Y by X when Z", "Passed to Y by X"); full sentences, as short as they can be, no label-colon-list; // goes wherever the code isn't obvious and says why, and the section banners and narration go. Every claim was checked against the code, which turned up some forty comments that were wrong: DumpCard's claimed it was only used by the hot and new feeds, the WebSocket welcome claimed to be a socket's first message (presence comes first), UpdateUserRequest said null removes a description (it keeps it), deletedDumpIds leaves out that it also holds dumps made private, THEME_COLOR claimed to mirror index.html's, and the like. The routers' JSDoc now says where they are mounted and what becomes of a thrown APIException. doc-lint.ts lets a field without a doc through; a module or export without one still fails. No code changes; 204 backend and 628 frontend tests pass, and doc:lint, deno check, deno lint and tsc are clean.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-29 14:31:14 +00:00

136 lines
3.4 KiB
TypeScript

/**
* Types the notifications `api/services/notification-service.ts` makes, and
* the data each kind carries. The client's `/notifications` page lists them
* and turns each into a sentence and a link.
*
* @module
*/
/**
* Says which of the `…Data` interfaces a notification's `data` is. Each value
* has one `notify…` trigger in `notification-service.ts`.
*/
export type NotificationType =
| "playlist_followed"
| "user_followed"
| "user_dump_posted"
| "playlist_dump_added"
| "dump_upvoted"
| "user_mentioned"
| "dump_commented"
| "comment_liked";
/**
* Carried by a `playlist_followed` notification, sent to a playlist's owner.
*/
export interface PlaylistFollowedData {
followerId: string;
followerUsername: string;
playlistId: string;
playlistTitle: string;
}
/** Carried by a `user_followed` notification, sent to the user followed. */
export interface UserFollowedData {
followerId: string;
followerUsername: string;
}
/**
* Carried by a `user_dump_posted` notification, sent to the followers of a
* user who posted a public dump.
*/
export interface UserDumpPostedData {
dumperId: string;
dumperUsername: string;
dumpId: string;
dumpTitle: string;
}
/**
* Carried by a `playlist_dump_added` notification, sent to the followers of a
* public playlist when a public dump is added to it.
*/
export interface PlaylistDumpAddedData {
dumpId: string;
dumpTitle: string;
playlistId: string;
playlistTitle: string;
}
/** Carried by a `dump_upvoted` notification, sent to the dump's poster. */
export interface DumpUpvotedData {
voterId: string;
voterUsername: string;
dumpId: string;
dumpTitle: string;
}
/**
* Carried by a `user_mentioned` notification, sent to a user @mentioned in a
* comment, a dump, a playlist's description or a chat message.
*/
export interface UserMentionedData {
mentionerId: string;
mentionerUsername: string;
contextType: "comment" | "dump" | "playlist" | "chat";
/** The id of the comment, dump, playlist or chat message. */
contextId: string;
/**
* The title of the dump or playlist, or of the dump a comment is under;
* empty for the chat.
*/
contextTitle: string;
/**
* Set only for a comment. It names the dump the comment is under, which the
* notification's link opens.
*/
dumpId?: string;
}
/** Carried by a `dump_commented` notification, sent to the dump's poster. */
export interface DumpCommentedData {
commenterId: string;
commenterUsername: string;
commentId: string;
dumpId: string;
dumpTitle: string;
}
/** Carried by a `comment_liked` notification, sent to the comment's author. */
export interface CommentLikedData {
likerId: string;
likerUsername: string;
commentId: string;
dumpId: string;
dumpTitle: string;
}
/**
* A snapshot taken when the notification is made: a name or title changed
* later still shows the old one. The notification's `type` says which member
* it is.
*/
export type NotificationData =
| PlaylistFollowedData
| UserFollowedData
| UserDumpPostedData
| PlaylistDumpAddedData
| DumpUpvotedData
| UserMentionedData
| DumpCommentedData
| CommentLikedData;
/**
* Pushed to its user's sockets in a `notification_created` message when it is
* made, and returned by `GET /api/notifications`.
*/
export interface Notification {
id: string;
userId: string;
type: NotificationType;
data: NotificationData;
read: boolean;
createdAt: Date;
}