Files
gerbeur/api/test/routes/attachments.test.ts
khannurien c3594e4c27 v4: what the server and the client both state is declared once — several rules were written out in two or more files, some already drifting apart. A link's site name (its host without www.) was computed in five places, now shared/url.ts's siteHost; dumpFileVersion, which the frontend and the server had to keep equal by hand, is one function in shared/dump.ts; the Markdown flattening of the chat's reply previews and the digest's quotes is shared/markdown.ts's markdownToPlainText, so the digest also keeps an image's alt text; an attachment's URL and how to find one in a text are shared/attachment.ts, which the editor, Markdown and attachment-service read, its id pattern the new UUID_RE that the file and thumbnail routes check ids with. On the server, the Bandcamp, YouTube playlist and link preview caches use one TtlCache (api/lib/ttl-cache.ts) instead of three copies of the same expiry and eviction; the link previews' theme-color and the emails' theme tokens read colours with one parser (api/lib/css-color.ts), and a transparent theme-color now gives no tint; the WebSocket route sends through ws-service's send, the welcome included, so it is type-checked; fetch.ts strips an IPv6 literal's brackets with public-address's bareHostname; and a category's slug is checked by the same validateSlug as a dump's, with its own length. The migrations keep their frozen copies, as they document. 272 backend tests and 677 frontend tests pass, and deno check, tsc, eslint and doc:lint are clean.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-09 13:16:52 +00:00

138 lines
4.4 KiB
TypeScript

import {
count,
createUser,
db,
del,
formWithFile,
get,
insertDump,
PNG,
post,
test,
} from "../helpers.ts";
import type { AttachmentResponse } from "../../../shared/attachment.ts";
import type { Comment } from "../../../shared/comment.ts";
import { assertEquals } from "@std/assert";
import { runStartupTasks } from "../../db/startup.ts";
test("attachments: upload an image, serve it back", async () => {
const user = await createUser();
const res = await post<AttachmentResponse>("/api/attachments", {
auth: user.auth,
form: formWithFile(PNG),
});
assertEquals(res.status, 201);
const id = res.data.id;
const served = await get(`/api/attachments/${id}`);
assertEquals(served.status, 200);
assertEquals(served.bytes, PNG);
assertEquals(served.headers.get("content-type"), "image/png");
assertEquals(served.headers.get("x-content-type-options"), "nosniff");
assertEquals(served.headers.get("cache-control"), "public, max-age=3600");
assertEquals(
(await get(`/api/attachments/${crypto.randomUUID()}`)).status,
404,
);
});
test("attachments: refuses non-images, non-multipart and anonymous uploads", async () => {
const user = await createUser();
assertEquals(
(await post("/api/attachments", {
auth: user.auth,
form: formWithFile(
new TextEncoder().encode("<script>"),
"x.png",
"image/png",
),
})).status,
400,
);
assertEquals(
(await post("/api/attachments", { auth: user.auth, json: {} })).status,
400,
);
const empty = new FormData();
empty.set("other", "x");
assertEquals(
(await post("/api/attachments", { auth: user.auth, form: empty })).status,
400,
);
assertEquals(
(await post("/api/attachments", { form: formWithFile(PNG) })).status,
401,
);
assertEquals(count(`SELECT COUNT(*) as n FROM attachments;`), 0);
});
test("attachments are claimed by the first text that links them", async () => {
const user = await createUser();
const { id: dumpId } = insertDump({ userId: user.id });
const up = await post<AttachmentResponse>("/api/attachments", {
auth: user.auth,
form: formWithFile(PNG),
});
const attachmentId = up.data.id;
const link = `![img](/api/attachments/${attachmentId})`;
const comment = await post<Comment>(`/api/dumps/${dumpId}/comments`, {
auth: user.auth,
json: { body: link },
});
const owner = () =>
(db.prepare(`SELECT resource_id FROM attachments WHERE id = ?;`).get(
attachmentId,
) as { resource_id: string | null }).resource_id;
assertEquals(owner(), comment.data.id);
// A second text can't take it over.
await post(`/api/dumps/${dumpId}/comments`, {
auth: user.auth,
json: { body: link },
});
assertEquals(owner(), comment.data.id);
});
test("attachments in a private dump need its owner's media token", async () => {
const owner = await createUser();
const other = await createUser();
const up = await post<AttachmentResponse>("/api/attachments", {
auth: owner.auth,
form: formWithFile(PNG),
});
const id = up.data.id;
const { id: dumpId } = insertDump({ userId: owner.id, isPrivate: true });
await post(`/api/dumps/${dumpId}/comments`, {
auth: owner.auth,
json: { body: `![img](/api/attachments/${id})` },
});
assertEquals((await get(`/api/attachments/${id}`)).status, 404);
assertEquals(
(await get(`/api/attachments/${id}?token=${other.mediaToken}`)).status,
404,
);
const served = await get(`/api/attachments/${id}?token=${owner.mediaToken}`);
assertEquals(served.status, 200);
assertEquals(served.headers.get("cache-control"), "private, max-age=3600");
});
test("attachments of a deleted resource are gone, and purged at startup", async () => {
const user = await createUser();
const up = await post<AttachmentResponse>("/api/attachments", {
auth: user.auth,
form: formWithFile(PNG),
});
const id = up.data.id;
const { id: dumpId } = insertDump({ userId: user.id });
const comment = await post<Comment>(`/api/dumps/${dumpId}/comments`, {
auth: user.auth,
json: { body: `![img](/api/attachments/${id})` },
});
assertEquals((await get(`/api/attachments/${id}`)).status, 200);
await del(`/api/comments/${comment.data.id}`, { auth: user.auth });
assertEquals((await get(`/api/attachments/${id}`)).status, 404);
await runStartupTasks(db);
assertEquals(
count(`SELECT COUNT(*) as n FROM attachments WHERE id = ?;`, id),
0,
);
});