54e86c4366
All checks were successful
Build and Publish Docker Image / build-and-push (push) Successful in 48s
Fixed along the way. Dumps: clearing a dump's note sent `comment: undefined`, which JSON drops, so the server kept the old one; it's sent as null now. Replacing a file dropped a visibility change made in the same save (the file endpoint doesn't read it); it follows as a separate update. Renaming a dump onto a new slug kept showing the old title until reload. The thumbnail picker and delete on the edit page failed without a word, the latter as an unhandled rejection. Playlists: an edit that kept the slug waited on the socket's echo to show, and a new cover never appeared (the upload's answer was ignored, a refused one said nothing); covers were also served stale for an hour, since `max-age=3600` met an unversioned URL — setPlaylistImage now bumps updated_at and every cover URL carries `?v=` (playlistImageUrl). Removing a dump, reordering, and deleting a playlist ignored non-OK answers, leaving page and server apart; they restore, reload or report. Profile: clearing "Who am I?" sent undefined and came back on reload; your own upvoted list (and the upvoted page) was empty until the socket's welcome, and forever without one; "View all" under Following linked to a route that doesn't exist and is a Load more now. Chat: Escape on "Delete this message?" closed the whole chat — ConfirmModal takes Escape first, in the capture phase. Player: a pause or play from a media key, headset or the OS wasn't reflected (MediaPlayer follows the element's own play/pause events), and the seek bar tracked dragging with mouse events only, so on touch the thumb fought timeupdate. Feeds: a guest on /~/followed got a blank page; a server error in the followed feed read as "Could not connect". Search: a failed later page threw away the results shown. Notifications: a failed mark-read replaced a loaded list with an error. Silent failures now say so: deleting a comment, the voters/likers "Load more" (stuck on "Loading…"), and the password-reset request, which said "sent" whatever happened. Notifications also stop hiding what was new: the bell still clears on opening the page, but the dots and the "N new" count stay for the visit instead of vanishing the moment the mark-read lands, and one arriving while the page is open is marked read too, so the bell doesn't count it. Accessibility: Modal and ConfirmModal are dialogs (role, aria-modal, labelled/described); playlist membership rows are checkboxes that work from the keyboard; a dump's title, and the profile's email and description, can be opened for editing from the keyboard (the pencil shows on focus); the category editor's ✓ and the global player's video button have names. Player, rich-content and download labels were hard-coded English and are translated, with the new French strings. Lint: fast-refresh and render-purity rules are off for src/test/ only, where probes hand their context out on purpose. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
39 lines
1.0 KiB
TypeScript
39 lines
1.0 KiB
TypeScript
import type { ReactNode } from "react";
|
|
import { useFormState } from "react-hook-form";
|
|
|
|
interface SubmitButtonProps {
|
|
children: ReactNode;
|
|
/** Replaces the label while the form is submitting (e.g. "Saving…"). */
|
|
pendingLabel?: ReactNode;
|
|
disabled?: boolean;
|
|
className?: string;
|
|
/** For an icon-only button (e.g. "✓"), its accessible name. */
|
|
"aria-label"?: string;
|
|
}
|
|
|
|
/**
|
|
* Submit button that reflects react-hook-form's `isSubmitting` from the
|
|
* surrounding `FormProvider`: it disables itself while submitting and swaps in
|
|
* `pendingLabel`. Standardizes the hand-rolled "Save → Saving…" pattern.
|
|
*/
|
|
export function SubmitButton({
|
|
children,
|
|
pendingLabel,
|
|
disabled,
|
|
className = "btn-primary",
|
|
"aria-label": ariaLabel,
|
|
}: SubmitButtonProps) {
|
|
const { isSubmitting } = useFormState();
|
|
|
|
return (
|
|
<button
|
|
type="submit"
|
|
className={className}
|
|
disabled={isSubmitting || disabled}
|
|
aria-label={ariaLabel}
|
|
>
|
|
{isSubmitting && pendingLabel != null ? pendingLabel : children}
|
|
</button>
|
|
);
|
|
}
|