Files
gerbeur/api/test/middleware/og.test.ts
khannurien 4468438ba7 v4: every page and API URL follows one of two rules, written down in API.md — pages are a hierarchy where @name is a user and any other root word a category or an app page, tabs and views are plain segments and a default view is the bare path; API resources are /api/<plural>/<key>, a user's key being an id or @name, the caller's things under /api/me, media a sub-resource, lookups by another key a query filter. ~ is gone: the feed is /, /hot, /new, /journal, /follow and /music/hot, a profile /@bob with its overview and the tabs dumps, upvoted, playlists (her own only), follow (users, and /follow/playlists), invitees and manage (role and name, for user:manage), which replace the separate UserDumps, UserUpvoted and UserPlaylists pages; /settings holds the account (now with the username) and /manage the category manager, both linked from the user menu and one's profile. Dumps and playlists live under their owner, /@bob/dumps/<slug> and /@bob/playlists/<slug>, named by slug alone: migration 0021 re-slugs them to the bare slugify(title), unique per owner and kind (the oldest keeps it, clashes get -2), renames the categories whose slug v4 reserves (hot, follow, settings…), and rewrites this site's v3 links in dump notes, comments, chat, and playlist and profile descriptions. A slug changes only when edited, through the edit forms' new link field, which proposes slugify(title) as the title changes; a username changes from /settings or, for user:manage, from /@name/manage. Every slug or name left behind stays an alias of its item or user for good (dump_slug_aliases, playlist_slug_aliases, user_aliases), so old links redirect without chaining and nobody else can take one; slugs change 3 times a day per item, names once in 30 days, moderators exempt. An alias, or a name in another case, answers the item with its current path: the pages put it in their URL (useCanonicalPath, without fetching again), and the OG middleware answers a 301. shared/paths.ts builds and parses every page path, for the client's links, the emails' (digest-service lost its own builders and its id fallbacks, and links /follow and /settings) and the server's matchers (OG tags, self previews, backlinks, self-url); shared/slug.ts holds slugify and the format categories share. Dumps and playlists carry ownerUsername and a required slug, and notifications join their users' current names and their items' paths each time they are sent or read, so renames reach them and a deleted item's has no link. The API was renamed per the plan's table: POST /api/users and /api/sessions, /api/password-resets, /api/me (with settings, password, avatar, media-token, playlists?contains=, follow, feed?from=, notifications), /api/users/:key/{dumps,upvoted,playlists,follow/users,follow/playlists,invitees,avatar} and by path /api/users/:key/{dumps,playlists}/:slug, /api/dumps?url= and ?category=, /api/dumps/:id/{file,thumbnail,metadata}, /api/playlists/:id/cover, /api/remote/{preview,image,bandcamp,youtube} (one router), and /api/unsubscribe, the v3 POST /api/users/unsubscribe staying for the digests already sent. A stored default feed tab "followed" reads as "follow" once. dumps.slug and playlists.slug stay nullable, since SQLite can't add NOT NULL without rebuilding tables others reference; every writer sets them and unique (user_id, slug) indexes hold them. 254 backend tests (new: migration 0021 on a v3 fixture, slug aliases, swaps and rate limits, username renames, aliases and limits, reads by path and their privacy, the OG 301s, both unsubscribe paths, v4-shaped digest links with no ids, notification joins, shared paths and slugs) and 668 frontend tests (new: the profile's tabs and follow views, Settings, Manage, the link field, canonical URLs on the dump, playlist and profile pages, bare default feed paths) pass, and tsc, eslint, deno check, deno lint, deno fmt and doc:lint are clean; the migration was also run on a copy of the development database.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-06 16:08:59 +00:00

164 lines
5.1 KiB
TypeScript

import {
BASE_URL,
createUser,
db,
insertDump,
insertPlaylist,
test,
} from "../helpers.ts";
import { assertEquals, assertFalse, assertStringIncludes } from "@std/assert";
import { Application } from "@oak/oak";
import { ogMiddleware } from "../../middleware/og.ts";
async function handle(
app: Application,
path: string,
headers: HeadersInit = {},
) {
const res = await app.handle(new Request(`${BASE_URL}${path}`, { headers }));
if (!res) throw new Error("no response");
return { res, text: await res.text() };
}
function ogApp() {
const app = new Application();
app.use(ogMiddleware);
app.use((ctx) => {
ctx.response.body = "fallthrough";
});
return app;
}
test("ogMiddleware: dump pages get escaped OG tags", async () => {
const user = await createUser();
const dump = insertDump({
userId: user.id,
title: `Tom & "Jerry" <script>`,
comment: "A comment",
richContent: {
type: "generic",
url: "x",
thumbnailUrl: "https://img.test/a.jpg",
},
});
const { res, text } = await handle(ogApp(), dump.path);
assertEquals(res.headers.get("content-type"), "text/html; charset=utf-8");
assertStringIncludes(
text,
`<meta property="og:title" content="Tom &amp; &quot;Jerry&quot; &lt;script&gt;" />`,
);
assertStringIncludes(
text,
`<title>Tom &amp; &quot;Jerry&quot; &lt;script&gt;</title>`,
);
assertStringIncludes(
text,
`<meta property="og:description" content="A comment" />`,
);
assertStringIncludes(
text,
`<meta property="og:image" content="https://img.test/a.jpg" />`,
);
assertStringIncludes(text, `content="summary_large_image"`);
assertStringIncludes(
text,
`<meta property="og:url" content="${BASE_URL}${dump.path}" />`,
);
// The index's own title is replaced, not duplicated.
assertEquals(text.match(/<title>/g)?.length, 1);
assertFalse(text.includes("__SITE_NAME__"));
});
test("ogMiddleware: no artwork falls back to the site icon as a small card", async () => {
const user = await createUser();
const dump = insertDump({ userId: user.id, title: "Plain" });
const { text } = await handle(ogApp(), dump.path);
assertStringIncludes(text, `content="${BASE_URL}/apple-touch-icon.png"`);
assertStringIncludes(text, `<meta name="twitter:card" content="summary" />`);
const file = insertDump({
userId: user.id,
fileName: "a.png",
fileMime: "image/png",
});
assertStringIncludes(
(await handle(ogApp(), file.path)).text,
`content="${BASE_URL}/api/dumps/${file.id}/file"`,
);
});
test("ogMiddleware: users and public playlists; private things fall through", async () => {
const user = await createUser();
const app = ogApp();
assertStringIncludes(
(await handle(app, `/@${user.username}/upvoted`)).text,
`<meta property="og:title" content="${user.username}" />`,
);
assertEquals(
(await handle(app, `/@${user.username}/nope`)).text,
"fallthrough",
);
const pub = insertPlaylist({ userId: user.id, title: "Open list" });
assertStringIncludes(
(await handle(app, pub.path)).text,
"Open list",
);
const priv = insertPlaylist({
userId: user.id,
title: "Closed",
isPublic: false,
});
assertEquals(
(await handle(app, priv.path)).text,
"fallthrough",
);
const secret = insertDump({
userId: user.id,
title: "Secret",
isPrivate: true,
});
assertEquals((await handle(app, secret.path)).text, "fallthrough");
assertEquals(
(await handle(app, `/@${user.username}/dumps/nope`)).text,
"fallthrough",
);
// v3 paths aren't redirected.
assertEquals((await handle(app, `/dumps/${secret.id}`)).text, "fallthrough");
assertEquals(
(await handle(app, `/api/dumps/${secret.id}`)).text,
"fallthrough",
);
assertEquals((await handle(app, `/favicon.ico`)).text, "fallthrough");
});
test("ogMiddleware: a former slug, a former name or another case gets a 301", async () => {
const user = await createUser();
const dump = insertDump({ userId: user.id, title: "Now" });
db.prepare(
`INSERT INTO dump_slug_aliases (user_id, slug, dump_id, created_at) VALUES (?, 'before', ?, ?);`,
).run(user.id, dump.id, new Date().toISOString());
db.prepare(
`INSERT INTO user_aliases (username, user_id, created_at) VALUES ('old_name', ?, ?);`,
).run(user.id, new Date().toISOString());
for (
const [from, to] of [
[`/@${user.username}/dumps/before?x=1`, `${dump.path}?x=1`],
[`/@OLD_NAME/dumps/now`, dump.path],
[`/@old_name/follow/playlists`, `/@${user.username}/follow/playlists`],
[`/@${user.username.toUpperCase()}`, `/@${user.username}`],
]
) {
const { res } = await handle(ogApp(), from);
assertEquals(res.status, 301, from);
assertEquals(res.headers.get("location"), `${BASE_URL}${to}`, from);
}
// A private dump's former slug tells nothing.
const secret = insertDump({ userId: user.id, title: "S", isPrivate: true });
db.prepare(
`INSERT INTO dump_slug_aliases (user_id, slug, dump_id, created_at) VALUES (?, 'hush', ?, ?);`,
).run(user.id, secret.id, new Date().toISOString());
assertEquals(
(await handle(ogApp(), `/@${user.username}/dumps/hush`)).text,
"fallthrough",
);
});