v4: what the server and the client both state is declared once — several rules were written out in two or more files, some already drifting apart. A link's site name (its host without www.) was computed in five places, now shared/url.ts's siteHost; dumpFileVersion, which the frontend and the server had to keep equal by hand, is one function in shared/dump.ts; the Markdown flattening of the chat's reply previews and the digest's quotes is shared/markdown.ts's markdownToPlainText, so the digest also keeps an image's alt text; an attachment's URL and how to find one in a text are shared/attachment.ts, which the editor, Markdown and attachment-service read, its id pattern the new UUID_RE that the file and thumbnail routes check ids with. On the server, the Bandcamp, YouTube playlist and link preview caches use one TtlCache (api/lib/ttl-cache.ts) instead of three copies of the same expiry and eviction; the link previews' theme-color and the emails' theme tokens read colours with one parser (api/lib/css-color.ts), and a transparent theme-color now gives no tint; the WebSocket route sends through ws-service's send, the welcome included, so it is type-checked; fetch.ts strips an IPv6 literal's brackets with public-address's bareHostname; and a category's slug is checked by the same validateSlug as a dump's, with its own length. The migrations keep their frozen copies, as they document. 272 backend tests and 677 frontend tests pass, and deno check, tsc, eslint and doc:lint are clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
khannurien
2026-10-09 13:10:07 +00:00
parent 134d1a0b97
commit c3594e4c27
39 changed files with 445 additions and 360 deletions

View File

@@ -16,18 +16,11 @@
*/
import { BASE_STYLE, type StyleName } from "../../shared/theme.ts";
import { hexOf, parseCssColor, type Rgba } from "../lib/css-color.ts";
/** A scheme a token is resolved for. "auto" is drawn from both. */
export type Scheme = "light" | "dark";
/** An sRGB color with its alpha, each channel 0–255 and alpha 0–1. */
interface Rgba {
r: number;
g: number;
b: number;
a: number;
}
/**
* Returned by {@link readTokens}: the tokens of one style in one scheme, read
* as the kind of value each is.
@@ -134,33 +127,16 @@ function replaceCalls(
/** Parses a CSS color in the forms the themes write, or throws. */
function parseColor(text: string): Rgba {
const value = text.trim().toLowerCase();
if (value === "transparent") return { r: 0, g: 0, b: 0, a: 0 };
const hex = value.match(/^#([0-9a-f]{3,8})$/)?.[1];
if (hex && hex.length !== 5 && hex.length !== 7) {
const full = hex.length <= 4 ? [...hex].map((c) => c + c).join("") : hex;
const channel = (i: number) => parseInt(full.slice(i * 2, i * 2 + 2), 16);
return {
r: channel(0),
g: channel(1),
b: channel(2),
a: full.length === 8 ? channel(3) / 255 : 1,
};
}
const rgb = value.match(/^rgba?\((.*)\)$/)?.[1];
if (rgb) {
const [r, g, b, a = "1"] = rgb.split(/[\s,/]+/).filter(Boolean);
const alpha = a.endsWith("%") ? parseFloat(a) / 100 : parseFloat(a);
return { r: +r, g: +g, b: +b, a: alpha };
}
throw new Error(`Unreadable color: ${text}`);
const color = parseCssColor(text);
if (!color) throw new Error(`Unreadable color: ${text}`);
return color;
}
/** Writes `color` as `#rrggbb`, or as `rgba()` when it is translucent. */
function formatColor({ r, g, b, a }: Rgba): string {
const [R, G, B] = [r, g, b].map((c) => Math.round(c));
if (a < 1) return `rgba(${R},${G},${B},${+a.toFixed(3)})`;
return `#${[R, G, B].map((c) => c.toString(16).padStart(2, "0")).join("")}`;
function formatColor(color: Rgba): string {
if (color.a >= 1) return hexOf(color);
const [r, g, b] = [color.r, color.g, color.b].map(Math.round);
return `rgba(${r},${g},${b},${+color.a.toFixed(3)})`;
}
/** Returns `top` laid over `under`, both straight (not premultiplied) alpha. */