v3: code quality pass

api/services/comment-service.ts

@@ -4,12 +4,7 @@ import {
   type Comment,
 } from "../model/interfaces.ts";
 import { type SQLOutputValue } from "node:sqlite";
-import {
-  type CommentRow,
-  commentRowToApi,
-  db,
-  isCommentRow,
-} from "../model/db.ts";
+import { commentRowToApi, db, isCommentRow } from "../model/db.ts";
 import { notifyMentions } from "./notification-service.ts";
 
 const SELECT_COLS =
@@ -23,7 +18,14 @@ function fetchComment(commentId: string): Comment {
   if (!row || !isCommentRow(row as Record<string, SQLOutputValue>)) {
     throw new APIException(APIErrorCode.NOT_FOUND, 404, "Comment not found");
   }
-  return commentRowToApi(row as CommentRow);
+  if (!isCommentRow(row)) {
+    throw new APIException(
+      APIErrorCode.SERVER_ERROR,
+      500,
+      "Malformed comment data",
+    );
+  }
+  return commentRowToApi(row);
 }
 
 export function getComments(dumpId: string): Comment[] {
@@ -31,15 +33,14 @@ export function getComments(dumpId: string): Comment[] {
     `SELECT ${SELECT_COLS} FROM comments c JOIN users u ON c.user_id = u.id
      WHERE c.dump_id = ? ORDER BY c.created_at ASC;`,
   ).all(dumpId);
-  const typed = rows as Parameters<typeof isCommentRow>[0][];
-  if (!typed.every(isCommentRow)) {
+  if (!rows.every(isCommentRow)) {
     throw new APIException(
       APIErrorCode.SERVER_ERROR,
       500,
       "Malformed comment data",
     );
   }
-  return typed.map(commentRowToApi);
+  return rows.map(commentRowToApi);
 }
 
 export function createComment(