v3: code quality pass

api/model/interfaces.ts

@@ -310,7 +310,7 @@ export interface CreatePlaylistRequest {
 
 export interface UpdatePlaylistRequest {
   title?: string;
-  description?: string;
+  description?: string | null;
   isPublic?: boolean;
 }
 
@@ -428,40 +428,33 @@ export function isUpdateDumpRequest(obj: unknown): obj is UpdateDumpRequest {
  * WebSockets
  */
 
+// ── Client → Server ──────────────────────────────────────────────────────────
+
+export interface PingMessage {
+  type: "ping";
+}
+
+export interface PongMessage {
+  type: "pong";
+}
+
 export interface VoteCastMessage {
   type: "vote_cast";
   dumpId: string;
-  userId: string;
 }
 
-export interface VoteAckMessageFailure {
-  type: "vote_ack";
-  dumpId: string;
-  success: false;
-  error: APIError;
-}
-
-export interface VoteAckMessageSuccess {
-  type: "vote_ack";
-  dumpId: string;
-  action: "cast" | "remove";
-  success: true;
-  voteCount: number;
-  error?: never;
-}
-
-export type VoteAckMessage = VoteAckMessageSuccess | VoteAckMessageFailure;
-
 export interface VoteRemoveMessage {
   type: "vote_remove";
   dumpId: string;
 }
 
-export interface VotesUpdateMessage {
-  type: "votes_update";
-  dumpId: string;
-  voteCount: number;
-}
+export type ClientToServerMessage =
+  | PingMessage
+  | PongMessage
+  | VoteCastMessage
+  | VoteRemoveMessage;
+
+// ── Server → Client ──────────────────────────────────────────────────────────
 
 export interface OnlineUser {
   userId: string;
@@ -474,6 +467,7 @@ export interface WelcomeMessage {
   type: "welcome";
   users: OnlineUser[];
   myVotes: string[];
+  unreadNotificationCount: number;
 }
 
 export interface PresenceUpdateMessage {
@@ -481,14 +475,109 @@ export interface PresenceUpdateMessage {
   users: OnlineUser[];
 }
 
-export interface PingMessage {
-  type: "ping";
+export interface VotesUpdateMessage {
+  type: "votes_update";
+  dumpId: string;
+  voteCount: number;
+  voterId: string;
+  action: "cast" | "remove";
 }
 
-export interface PongMessage {
-  type: "pong";
+export interface VoteAckMessage {
+  type: "vote_ack";
+  dumpId: string;
+  action: "cast" | "remove";
+  voteCount: number;
 }
 
+export interface DumpCreatedMessage {
+  type: "dump_created";
+  dump: Dump;
+}
+
+export interface DumpUpdatedMessage {
+  type: "dump_updated";
+  dump: Dump;
+}
+
+export interface DumpDeletedMessage {
+  type: "dump_deleted";
+  dumpId: string;
+}
+
+export interface PlaylistCreatedMessage {
+  type: "playlist_created";
+  playlist: Playlist;
+}
+
+export interface PlaylistUpdatedMessage {
+  type: "playlist_updated";
+  playlist: Playlist;
+}
+
+export interface PlaylistDeletedMessage {
+  type: "playlist_deleted";
+  playlistId: string;
+  userId: string;
+}
+
+export interface PlaylistDumpsUpdatedMessage {
+  type: "playlist_dumps_updated";
+  playlistId: string;
+  dumpIds: string[];
+}
+
+export interface UserUpdatedMessage {
+  type: "user_updated";
+  user: Omit<User, "passwordHash">;
+}
+
+export interface CommentCreatedMessage {
+  type: "comment_created";
+  comment: Comment;
+}
+
+export interface CommentUpdatedMessage {
+  type: "comment_updated";
+  comment: Comment;
+}
+
+export interface CommentDeletedMessage {
+  type: "comment_deleted";
+  commentId: string;
+  dumpId: string;
+}
+
+export interface NotificationCreatedMessage {
+  type: "notification_created";
+  notification: RawNotification;
+}
+
+export interface ErrorMessage {
+  type: "error";
+  message?: string;
+}
+
+export type ServerToClientMessage =
+  | PingMessage
+  | WelcomeMessage
+  | PresenceUpdateMessage
+  | VotesUpdateMessage
+  | VoteAckMessage
+  | DumpCreatedMessage
+  | DumpUpdatedMessage
+  | DumpDeletedMessage
+  | PlaylistCreatedMessage
+  | PlaylistUpdatedMessage
+  | PlaylistDeletedMessage
+  | PlaylistDumpsUpdatedMessage
+  | UserUpdatedMessage
+  | CommentCreatedMessage
+  | CommentUpdatedMessage
+  | CommentDeletedMessage
+  | NotificationCreatedMessage
+  | ErrorMessage;
+
 /**
  * Follows
  */
@@ -568,3 +657,8 @@ export interface Notification {
   read: boolean;
   createdAt: Date;
 }
+
+/** Wire format — createdAt arrives as an ISO string over JSON. */
+export type RawNotification = Omit<Notification, "createdAt"> & {
+  createdAt: string;
+};