v3: fix the backend's correctness findings — each by a rule shared across the code rather than one more special case. Link previews: readTextCapped decoded every page as UTF-8, so a Latin-1 page came out garbled unless it went through the curl fallback, which re-encoded it on its own; pages are now decoded in the charset their Content-Type or <meta> declares, and the curl fallback hands the bytes over as they are. The image proxy served and cached for a day an error answer that claimed an image type, and read a body without Content-Length whole before checking its size; it now refuses an error status and reads through the same capped reader. The icons task's Twemoji fetch gives up after 15 s instead of holding the start up, and extractLinkHref, which only its tests used, is gone. Backlinks matched a linked URL against the raw url column, so https://x.com/ missed a dump posted as https://x.com; they now compare canonical URLs, as reposts do. The four LIKE searches put the query in raw, so % and _ were wildcards and the mention search for "a_b" found "axb"; lib/like.ts escapes them. Every list query now treats a malformed row the same way, a 500 through model/rows.ts's parseRows, where ten of them silently dropped it; the playlist dumps query uses the model's column list rather than a hand-written copy, and the aliased list is derived from the plain one. The vote and like services commit through transaction() instead of their own BEGIN and ROLLBACK, which would have rolled back a caller's transaction.

Validation: the dump validators refuse the nulls their shared types don't allow (a null title or note on creation, a null URL on edit); a playlist title of spaces is refused and titles are stored trimmed; usernames and emails are checked by the same USERNAME_RE and EMAIL_RE in shared/validation.ts on sign-up, on PATCH /api/users/me (which checked other limits) and in the sign-up form. Mentions are read by shared/mention.ts's mentionedUsernames, which skips code and URLs as Markdown shows them: https://mastodon.social/@bob or a `@bob` in code notified bob; the editor's suggestions derive their trigger from the same pattern instead of a copy. Following an unknown user is a 404 rather than a foreign-key 500, and following a private playlist a 404 rather than a 403 that confirmed it exists. `ws` and `emojibase` are reserved category slugs, since the server answers them before the app. GET /api/users/me no longer turns every error into a 500.

Dead code goes: adminOnlyMiddleware, verifyEmailTransport, listUsers, deleteUser with disconnectUser and the force_logout message only it sent, PATCH /api/notifications/:id/read (with markOneRead), isSlugAvailable, the unreachable 500 in fetchComment, and the `if (!ctx.state.user)` checks behind authMiddleware. 214 backend and 627 frontend tests pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

api/services/user-service.ts

@@ -24,10 +24,12 @@ import {
   userRowToApi,
 } from "../model/user.ts";
 import { db } from "../db/connection.ts";
-import { closeUserSockets, disconnectUser } from "./ws-service.ts";
+import { closeUserSockets } from "./ws-service.ts";
 
 import { hashPassword } from "../lib/password.ts";
 import { linkAttachments } from "./attachment-service.ts";
+import { LIKE, likePattern } from "../lib/like.ts";
+import { parseRows } from "../model/rows.ts";
 
 /** Selects full `UserRow`s from `users u`, with the inviter's name joined. */
 const USER_SELECT =
@@ -194,8 +196,8 @@ export function searchUsers(
 ): UserSuggestion[] {
   if (!query) return [];
   const rows = db.prepare(
-    `SELECT id, username, avatar_mime FROM users WHERE username LIKE ? ORDER BY username LIMIT ?;`,
-  ).all(`${query}%`, limit) as {
+    `SELECT id, username, avatar_mime FROM users WHERE username ${LIKE} ORDER BY username LIMIT ?;`,
+  ).all(likePattern(query, "prefix"), limit) as {
     id: string;
     username: string;
     avatar_mime: string | null;
@@ -213,28 +215,11 @@ export function searchUsers(
  */
 export function searchUsersGlobal(query: string, limit: number): PublicUser[] {
   if (!query.trim()) return [];
-  const pattern = `%${query}%`;
+  const pattern = likePattern(query);
   const rows = db.prepare(
-    `${USER_SELECT} WHERE (u.username LIKE ? OR u.description LIKE ?) ORDER BY u.username LIMIT ?;`,
+    `${USER_SELECT} WHERE (u.username ${LIKE} OR u.description ${LIKE}) ORDER BY u.username LIMIT ?;`,
   ).all(pattern, pattern, limit);
-  return rows.filter(isUserRow).map(userRowToApi).map(toPublicUser);
-}
-
-/**
- * Returns every user. Nothing calls it.
- *
- * @throws {APIException} 404 when a row doesn't parse as a user.
- */
-export function listUsers(): User[] {
-  const userRows = db.prepare(
-    `${USER_SELECT}`,
-  ).all();
-
-  if (!userRows || !userRows.every(isUserRow)) {
-    throw new APIException(404, "No user found");
-  }
-
-  return userRows.map(userRowToApi);
+  return parseRows(rows, isUserRow, userRowToApi).map(toPublicUser);
 }
 
 /**
@@ -357,20 +342,3 @@ export function getInviteTree(userId: string): Invitee[] {
     createdAt: new Date(r.created_at),
   }));
 }
-
-/**
- * Deletes user `userId` and disconnects their sockets. Nothing calls it.
- *
- * @throws {APIException} 404 when there is no such user.
- */
-export function deleteUser(userId: string): void {
-  disconnectUser(userId);
-
-  const result = db.prepare(
-    `DELETE FROM users WHERE id = ?;`,
-  ).run(userId);
-
-  if (result.changes === 0) {
-    throw new APIException(404, "User not found");
-  }
-}