v4: every page and API URL follows one of two rules, written down in API.md — pages are a hierarchy where @name is a user and any other root word a category or an app page, tabs and views are plain segments and a default view is the bare path; API resources are /api/<plural>/<key>, a user's key being an id or @name, the caller's things under /api/me, media a sub-resource, lookups by another key a query filter. ~ is gone: the feed is /, /hot, /new, /journal, /follow and /music/hot, a profile /@bob with its overview and the tabs dumps, upvoted, playlists (her own only), follow (users, and /follow/playlists), invitees and manage (role and name, for user:manage), which replace the separate UserDumps, UserUpvoted and UserPlaylists pages; /settings holds the account (now with the username) and /manage the category manager, both linked from the user menu and one's profile. Dumps and playlists live under their owner, /@bob/dumps/<slug> and /@bob/playlists/<slug>, named by slug alone: migration 0021 re-slugs them to the bare slugify(title), unique per owner and kind (the oldest keeps it, clashes get -2), renames the categories whose slug v4 reserves (hot, follow, settings…), and rewrites this site's v3 links in dump notes, comments, chat, and playlist and profile descriptions. A slug changes only when edited, through the edit forms' new link field, which proposes slugify(title) as the title changes; a username changes from /settings or, for user:manage, from /@name/manage. Every slug or name left behind stays an alias of its item or user for good (dump_slug_aliases, playlist_slug_aliases, user_aliases), so old links redirect without chaining and nobody else can take one; slugs change 3 times a day per item, names once in 30 days, moderators exempt. An alias, or a name in another case, answers the item with its current path: the pages put it in their URL (useCanonicalPath, without fetching again), and the OG middleware answers a 301. shared/paths.ts builds and parses every page path, for the client's links, the emails' (digest-service lost its own builders and its id fallbacks, and links /follow and /settings) and the server's matchers (OG tags, self previews, backlinks, self-url); shared/slug.ts holds slugify and the format categories share. Dumps and playlists carry ownerUsername and a required slug, and notifications join their users' current names and their items' paths each time they are sent or read, so renames reach them and a deleted item's has no link. The API was renamed per the plan's table: POST /api/users and /api/sessions, /api/password-resets, /api/me (with settings, password, avatar, media-token, playlists?contains=, follow, feed?from=, notifications), /api/users/:key/{dumps,upvoted,playlists,follow/users,follow/playlists,invitees,avatar} and by path /api/users/:key/{dumps,playlists}/:slug, /api/dumps?url= and ?category=, /api/dumps/:id/{file,thumbnail,metadata}, /api/playlists/:id/cover, /api/remote/{preview,image,bandcamp,youtube} (one router), and /api/unsubscribe, the v3 POST /api/users/unsubscribe staying for the digests already sent. A stored default feed tab "followed" reads as "follow" once. dumps.slug and playlists.slug stay nullable, since SQLite can't add NOT NULL without rebuilding tables others reference; every writer sets them and unique (user_id, slug) indexes hold them. 254 backend tests (new: migration 0021 on a v3 fixture, slug aliases, swaps and rate limits, username renames, aliases and limits, reads by path and their privacy, the OG 301s, both unsubscribe paths, v4-shaped digest links with no ids, notification joins, shared paths and slugs) and 668 frontend tests (new: the profile's tabs and follow views, Settings, Manage, the link field, canonical URLs on the dump, playlist and profile pages, bare default feed paths) pass, and tsc, eslint, deno check, deno lint, deno fmt and doc:lint are clean; the migration was also run on a copy of the development database.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
khannurien
206
src/test/pages/Settings.test.tsx
Normal file
206
src/test/pages/Settings.test.tsx
Normal file
@@ -0,0 +1,206 @@
|
||||
import { afterEach, describe, expect, test, vi } from "vitest";
|
||||
import { screen, waitFor, within } from "@testing-library/react";
|
||||
import { userEvent } from "@testing-library/user-event";
|
||||
import { Settings } from "../../pages/Settings.tsx";
|
||||
import { DEFAULT_SETTINGS } from "../../../shared/settings.ts";
|
||||
import { calls, fail, route } from "../fetch.ts";
|
||||
import { makeSession, makeToken, wire } from "../fixtures.ts";
|
||||
import { renderApp } from "../render.tsx";
|
||||
import { AUTH_STORAGE_KEY } from "../../utils/auth/storage.ts";
|
||||
|
||||
const instance = vi.hoisted(() => ({ emailEnabled: false }));
|
||||
vi.mock("../../config/instance.ts", () => ({
|
||||
DEFAULT_STYLE: "smooth",
|
||||
get EMAIL_ENABLED() {
|
||||
return instance.emailEnabled;
|
||||
},
|
||||
}));
|
||||
|
||||
const annSession = makeSession({
|
||||
id: "ann",
|
||||
username: "ann",
|
||||
email: "ann@x.test",
|
||||
});
|
||||
|
||||
function open(session = annSession) {
|
||||
const user = userEvent.setup();
|
||||
renderApp(<Settings />, { route: "/settings", path: "/settings", session });
|
||||
return user;
|
||||
}
|
||||
|
||||
const row = (label: string) =>
|
||||
screen.getByText(label).closest(".profile-appearance-row") as HTMLElement;
|
||||
|
||||
describe("Settings", () => {
|
||||
afterEach(() => {
|
||||
instance.emailEnabled = false;
|
||||
document.documentElement.removeAttribute("data-style");
|
||||
document.documentElement.removeAttribute("data-color-scheme");
|
||||
});
|
||||
|
||||
test("theme, colour scheme, default tab and sounds; no digests without SMTP", async () => {
|
||||
const user = open();
|
||||
expect(await screen.findByRole("heading", { name: "Settings" }))
|
||||
.toBeInTheDocument();
|
||||
await user.click(screen.getByRole("button", { name: "Brutalist" }));
|
||||
expect(document.documentElement.getAttribute("data-style")).toBe(
|
||||
"brutalist",
|
||||
);
|
||||
await user.click(screen.getByRole("button", { name: "Dark" }));
|
||||
expect(document.documentElement.getAttribute("data-color-scheme")).toBe(
|
||||
"dark",
|
||||
);
|
||||
await user.click(
|
||||
within(row("Default tab")).getByRole("button", { name: "Followed" }),
|
||||
);
|
||||
expect(localStorage.getItem("default-feed-tab")).toBe("follow");
|
||||
await user.click(
|
||||
within(row("Sounds")).getByRole("button", { name: "Off" }),
|
||||
);
|
||||
expect(localStorage.getItem("sounds")).toBe("off");
|
||||
expect(within(row("Weekly digest")).getByRole("button", { name: "On" }))
|
||||
.toBeDisabled();
|
||||
expect(screen.getByText(/doesn't send email/)).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test("the digest switches save to the account", async () => {
|
||||
instance.emailEnabled = true;
|
||||
route("GET /api/me/settings", () => ({
|
||||
...DEFAULT_SETTINGS,
|
||||
digestMonthly: false,
|
||||
}));
|
||||
route(
|
||||
"PATCH /api/me/settings",
|
||||
(req) => ({ ...DEFAULT_SETTINGS, ...(req.body as object) }),
|
||||
);
|
||||
const user = open();
|
||||
const weeklyOff = await waitFor(() => {
|
||||
const button = within(row("Weekly digest")).getByRole("button", {
|
||||
name: "Off",
|
||||
});
|
||||
expect(button).toBeEnabled();
|
||||
return button;
|
||||
});
|
||||
expect(
|
||||
within(row("Monthly recap")).getByRole("button", { name: "Off" }),
|
||||
).toHaveClass("active");
|
||||
expect(screen.queryByText(/doesn't send email/)).toBeNull();
|
||||
|
||||
await user.click(weeklyOff);
|
||||
await waitFor(() =>
|
||||
expect(calls("PATCH /api/me/settings")[0]?.body).toEqual({
|
||||
digestWeekly: false,
|
||||
})
|
||||
);
|
||||
expect(weeklyOff).toHaveClass("active");
|
||||
});
|
||||
|
||||
test("a new username goes to the account and the session", async () => {
|
||||
route(
|
||||
"PATCH /api/me",
|
||||
(req) => wire({ ...annSession.user, ...(req.body as object) }),
|
||||
);
|
||||
const user = open();
|
||||
const name = await screen.findByRole("textbox", { name: "Username" });
|
||||
expect(screen.getByText(/once every 30 days/)).toBeInTheDocument();
|
||||
const rename = screen.getByRole("button", { name: "Rename" });
|
||||
expect(rename).toBeDisabled();
|
||||
await user.clear(name);
|
||||
await user.type(name, "annie");
|
||||
await user.click(rename);
|
||||
await waitFor(() =>
|
||||
expect(JSON.parse(localStorage.getItem(AUTH_STORAGE_KEY)!).user.username)
|
||||
.toBe("annie")
|
||||
);
|
||||
expect(calls("PATCH /api/me")[0].body).toEqual({ username: "annie" });
|
||||
expect(screen.getByRole("textbox", { name: "Username" })).toHaveValue(
|
||||
"annie",
|
||||
);
|
||||
});
|
||||
|
||||
test("a refused username says why, and a malformed one isn't sent", async () => {
|
||||
route(
|
||||
"PATCH /api/me",
|
||||
() => fail("A username can only be changed once every 30 days", 429),
|
||||
);
|
||||
const user = open();
|
||||
const name = await screen.findByRole("textbox", { name: "Username" });
|
||||
await user.type(name, " x{Enter}");
|
||||
expect(await screen.findByText(/Letters, numbers and underscores/))
|
||||
.toBeInTheDocument();
|
||||
expect(calls("PATCH /api/me")).toHaveLength(0);
|
||||
await user.clear(name);
|
||||
await user.type(name, "annie{Enter}");
|
||||
expect(await screen.findByRole("alert")).toHaveTextContent(
|
||||
"once every 30 days",
|
||||
);
|
||||
});
|
||||
|
||||
test("change password keeps you signed in with the fresh tokens", async () => {
|
||||
const freshToken = makeToken({ sub: "ann" });
|
||||
route(
|
||||
"PUT /api/me/password",
|
||||
() => ({ token: freshToken, mediaToken: "fresh-media" }),
|
||||
);
|
||||
const user = open();
|
||||
await user.click(
|
||||
await screen.findByRole("button", { name: "Change password…" }),
|
||||
);
|
||||
const dialog = screen.getByRole("dialog", { name: "Change password" });
|
||||
await user.type(
|
||||
within(dialog).getByLabelText("Current password"),
|
||||
"oldpassword",
|
||||
);
|
||||
await user.type(
|
||||
within(dialog).getByLabelText("New password"),
|
||||
"newpassword",
|
||||
);
|
||||
await user.type(
|
||||
within(dialog).getByLabelText("Confirm new password"),
|
||||
"different",
|
||||
);
|
||||
expect(await within(dialog).findByText("Passwords do not match"))
|
||||
.toBeInTheDocument();
|
||||
await user.clear(within(dialog).getByLabelText("Confirm new password"));
|
||||
await user.type(
|
||||
within(dialog).getByLabelText("Confirm new password"),
|
||||
"newpassword",
|
||||
);
|
||||
await user.click(
|
||||
within(dialog).getByRole("button", { name: "Change password" }),
|
||||
);
|
||||
expect(await within(dialog).findByText("Password changed successfully."))
|
||||
.toBeInTheDocument();
|
||||
expect(JSON.parse(localStorage.getItem(AUTH_STORAGE_KEY)!).token).toBe(
|
||||
freshToken,
|
||||
);
|
||||
expect(calls("PUT /api/me/password")[0].body).toEqual({
|
||||
currentPassword: "oldpassword",
|
||||
newPassword: "newpassword",
|
||||
});
|
||||
});
|
||||
|
||||
test("a wrong current password is reported", async () => {
|
||||
route(
|
||||
"PUT /api/me/password",
|
||||
() => fail("Current password is incorrect", 400),
|
||||
);
|
||||
const user = open();
|
||||
await user.click(
|
||||
await screen.findByRole("button", { name: "Change password…" }),
|
||||
);
|
||||
const dialog = screen.getByRole("dialog", { name: "Change password" });
|
||||
await user.type(within(dialog).getByLabelText("Current password"), "wrong");
|
||||
await user.type(
|
||||
within(dialog).getByLabelText("New password"),
|
||||
"newpassword",
|
||||
);
|
||||
await user.type(
|
||||
within(dialog).getByLabelText("Confirm new password"),
|
||||
"newpassword{Enter}",
|
||||
);
|
||||
expect(await within(dialog).findByRole("alert")).toHaveTextContent(
|
||||
"Current password is incorrect",
|
||||
);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user