v4: /follow/playlists opens the followed playlists' feed, and a page's test opens it through the app's routes — the path was a 404 since the two views of the followed feed became pages: the route table held each feed tab as an exact path, /follow, so /follow/playlists fell to /:handle/*, which read "follow" as a category and "playlists" as a tab it hasn't. /music/follow/playlists, which goes through that route, worked. The tabs' routes now take what follows them (/${tab}/*), which Feed already reads and refuses when it names no view.
No test saw it because each page's test mounted the page on a route pattern of its own, a copy of App's, with stand-in pages where a redirect lands: Index's parsed the path itself, and passed on one the app doesn't serve. renderPage (src/test/render.tsx) now opens a URL through AppRoutes, which App.tsx exports for it, inside the real providers, and every page's test uses it: the page is the one the app routes that URL to, behind its guard, and a redirect is checked by the path it lands on. An entry may be a location, to arrive with the state a link hands over. Every page being loaded with its route, the first query after opening one waits. src/test/App.test.tsx tests the table itself: the paths that are a feed, those that are not found, those that send a guest to sign in and back, and those that send a signed-in user home. The profile's test held /@ann/dumps/x to be a path the profile answers as not found, which only its own pattern made true: in the app it is a dump's page. It now asks for /@ann/dumps/x/y. The tests of the two guards still mount them around a stand-in child, being tests of the guard alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,20 +1,14 @@
|
||||
import { describe, expect, test } from "vitest";
|
||||
import { screen } from "@testing-library/react";
|
||||
import { Route } from "react-router";
|
||||
import { FederationCallback } from "../../pages/FederationCallback.tsx";
|
||||
import { screen, waitFor } from "@testing-library/react";
|
||||
import { AUTH_STORAGE_KEY } from "../../utils/auth/storage.ts";
|
||||
import { calls, fail, route } from "../fetch.ts";
|
||||
import { makeSession, wire } from "../fixtures.ts";
|
||||
import { renderApp } from "../render.tsx";
|
||||
import { makeSession, page, wire } from "../fixtures.ts";
|
||||
import { currentPath, renderPage } from "../render.tsx";
|
||||
|
||||
/** Opens the callback, in a tab that started the sign-in of state `s`. */
|
||||
function open(query: string, started = "s") {
|
||||
sessionStorage.setItem("federationState", started);
|
||||
renderApp(<FederationCallback />, {
|
||||
route: `/federation/callback${query}`,
|
||||
path: "/federation/callback",
|
||||
extraRoutes: <Route path="/" element={<p>home page</p>} />,
|
||||
});
|
||||
renderPage(`/federation/callback${query}`);
|
||||
}
|
||||
|
||||
describe("FederationCallback", () => {
|
||||
@@ -23,8 +17,9 @@ describe("FederationCallback", () => {
|
||||
"POST /api/federation/sessions",
|
||||
() => wire(makeSession({ username: "alice@home.example" })),
|
||||
);
|
||||
route("GET /api/dumps", () => page([]));
|
||||
open("?code=c&state=s&iss=https%3A%2F%2Fhome.example");
|
||||
await screen.findByText("home page");
|
||||
await waitFor(() => expect(currentPath()).toBe("/"));
|
||||
expect(calls("POST /api/federation/sessions").map((c) => c.body)).toEqual(
|
||||
[{ code: "c", state: "s" }],
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user