v3: comments say what the code can't — the documentation pass wanted JSDoc on every export and every field of an exported interface, which filled the code with restatements ("The dump.", "Whether it is loading.", "The props of X.", "Renders the X.") and module docs that told a reader nothing ("The hot and new feeds, and the props every main feed of the index takes."); some were wrong as well as vague. Every comment in api/, shared/ and src/ is rewritten under one rule, now stated in the README's "Comments" section: every module and export still has a JSDoc, and it gives context (who uses it and where), usage (what a caller must know: a precondition, what it leaves to the caller, a side effect) or its place in the chain (where its input comes from, where its output goes); a field, parameter, private function or local gets one only when it adds to its parent's, and context about a whole type goes on the type; a type's doc is phrased from the value's side ("Returned to Y by X when Z", "Passed to Y by X"); full sentences, as short as they can be, no label-colon-list; // goes wherever the code isn't obvious and says why, and the section banners and narration go. Every claim was checked against the code, which turned up some forty comments that were wrong: DumpCard's claimed it was only used by the hot and new feeds, the WebSocket welcome claimed to be a socket's first message (presence comes first), UpdateUserRequest said null removes a description (it keeps it), deletedDumpIds leaves out that it also holds dumps made private, THEME_COLOR claimed to mirror index.html's, and the like. The routers' JSDoc now says where they are mounted and what becomes of a thrown APIException. doc-lint.ts lets a field without a doc through; a module or export without one still fails. No code changes; 204 backend and 628 frontend tests pass, and doc:lint, deno check, deno lint and tsc are clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
khannurien
2026-09-29 14:31:14 +00:00
parent 42e0356d21
commit 0d4e344d77
287 changed files with 5679 additions and 5135 deletions

View File

@@ -1,5 +1,5 @@
/**
* Guards for the user and authentication request bodies.
* Checks the JSON bodies that `routes/users.ts` receives before it reads them.
*
* @module
*/
@@ -12,14 +12,20 @@ import {
} from "../../shared/user.ts";
import { VALIDATION } from "../../shared/validation.ts";
/** Checks whether `obj` is a valid {@link LoginUserRequest}. */
/**
* Checks whether `obj` is a {@link LoginUserRequest}. It checks the types
* only: a wrong name or password is the login route's answer to give.
*/
export function isLoginUserRequest(obj: unknown): obj is LoginUserRequest {
return !!obj && typeof obj === "object" &&
"username" in obj && typeof obj.username === "string" &&
"password" in obj && typeof obj.password === "string";
}
/** Returns `obj[key]` when `obj` is an object that has it, else undefined. */
/**
* Returns `obj[key]` when `obj` is an object that has it, else undefined. The
* users routes whose body has no guard of its own read their fields with it.
*/
export function fieldOf(obj: unknown, key: string): unknown {
return obj !== null && typeof obj === "object" && key in obj
? (obj as Record<string, unknown>)[key]
@@ -27,8 +33,8 @@ export function fieldOf(obj: unknown, key: string): unknown {
}
/**
* Checks whether `obj` is a valid {@link RegisterUserRequest} (see
* {@link validateRegisterUserRequest}).
* Checks whether `obj` is a valid {@link RegisterUserRequest}. When it isn't,
* {@link validateRegisterUserRequest} says why.
*/
export function isRegisterUserRequest(
obj: unknown,
@@ -37,9 +43,10 @@ export function isRegisterUserRequest(
}
/**
* Checks a registration body — its shape, the email's form, and the username
* and password against the `VALIDATION` limits — and returns what is wrong
* with it, readable by the user, or null when it is valid.
* Returns what is wrong with a sign-up body, as the message the register page
* shows, or null when it is valid. It checks the shape, the email's form, and
* the username and password against the `VALIDATION` limits. Whether the name,
* the email or the invite is taken is `createUser`'s and `claimInvite`'s check.
*/
export function validateRegisterUserRequest(obj: unknown): string | null {
if (
@@ -71,8 +78,10 @@ export function validateRegisterUserRequest(obj: unknown): string | null {
}
/**
* Checks whether `obj` is a valid {@link UpdateUserRequest}: each field it
* carries well-formed, and within the `VALIDATION` limits.
* Checks whether `obj` is a valid {@link UpdateUserRequest}, for
* `PATCH /api/users/me`. Every field is optional, but each one present must be
* well-formed and within the `VALIDATION` limits. The username's limits here
* are not those of sign-up, which the route never lets it change anyway.
*/
export function isUpdateUserRequest(obj: unknown): obj is UpdateUserRequest {
if (!obj || typeof obj !== "object") return false;