v3: comments say what the code can't — the documentation pass wanted JSDoc on every export and every field of an exported interface, which filled the code with restatements ("The dump.", "Whether it is loading.", "The props of X.", "Renders the X.") and module docs that told a reader nothing ("The hot and new feeds, and the props every main feed of the index takes."); some were wrong as well as vague. Every comment in api/, shared/ and src/ is rewritten under one rule, now stated in the README's "Comments" section: every module and export still has a JSDoc, and it gives context (who uses it and where), usage (what a caller must know: a precondition, what it leaves to the caller, a side effect) or its place in the chain (where its input comes from, where its output goes); a field, parameter, private function or local gets one only when it adds to its parent's, and context about a whole type goes on the type; a type's doc is phrased from the value's side ("Returned to Y by X when Z", "Passed to Y by X"); full sentences, as short as they can be, no label-colon-list; // goes wherever the code isn't obvious and says why, and the section banners and narration go. Every claim was checked against the code, which turned up some forty comments that were wrong: DumpCard's claimed it was only used by the hot and new feeds, the WebSocket welcome claimed to be a socket's first message (presence comes first), UpdateUserRequest said null removes a description (it keeps it), deletedDumpIds leaves out that it also holds dumps made private, THEME_COLOR claimed to mirror index.html's, and the like. The routers' JSDoc now says where they are mounted and what becomes of a thrown APIException. doc-lint.ts lets a field without a doc through; a module or export without one still fails. No code changes; 204 backend and 628 frontend tests pass, and doc:lint, deno check, deno lint and tsc are clean.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
/**
|
||||
* Serving files from disk with ETags and byte ranges, streamed a chunk at a
|
||||
* time.
|
||||
* Sends files from disk with ETags and byte ranges, streamed a chunk at a
|
||||
* time. The files and thumbnails routes call it, and lib/upload.ts for the
|
||||
* other uploads.
|
||||
*
|
||||
* @module
|
||||
*/
|
||||
@@ -67,21 +68,24 @@ function matchesEtag(header: string | null, etag: string): boolean {
|
||||
return header.split(",").some((tag) => strip(tag) === strip(etag));
|
||||
}
|
||||
|
||||
/** How {@link serveFile} answers. */
|
||||
/**
|
||||
* Passed to {@link serveFile} by its caller, which knows the file's type and
|
||||
* how long it may be cached.
|
||||
*/
|
||||
export interface ServeFileOptions {
|
||||
/** The `Content-Type` sent. */
|
||||
mime: string;
|
||||
/** The `Cache-Control` sent. */
|
||||
cacheControl: string;
|
||||
/** Answer a single `Range: bytes=…` with a 206 (media files). */
|
||||
/**
|
||||
* Answers a single `Range: bytes=…` with a 206. The files route sets it, so
|
||||
* that audio and video can seek.
|
||||
*/
|
||||
ranges?: boolean;
|
||||
}
|
||||
|
||||
/**
|
||||
* Sends a file from disk with an ETag (a 304 when the client already has it)
|
||||
* and, when `ranges` is set, single byte ranges. The body is streamed.
|
||||
*
|
||||
* Returns false, having sent nothing, when the file doesn't exist.
|
||||
* Sends a file from disk with an ETag, answering 304 when the client already
|
||||
* has it, and single byte ranges when `ranges` is set. It returns false, having
|
||||
* sent nothing, when the file doesn't exist, and leaves the 404 to the caller.
|
||||
*/
|
||||
export async function serveFile(
|
||||
ctx: Context,
|
||||
|
||||
Reference in New Issue
Block a user