v3: every paged list loads its pages one way, PlaylistDetail is split like the profile, and the comments keep the README's rules — Index, FollowedFeed, useUserDumpFeed, UserPlaylists, UserListPopover, Notifications, Search and the profile's followed users each hand-wrote "fetch the next page, append it, clear loadingMore on failure". A list the API pages is now a PagedList whose next page useLoadMore appends, and a list that loads on its own goes through usePagedList, which is useFetchState (now taking an initial value, as a restored cache, that starts loaded) plus useLoadMore. Pages are read by pageUrl with readPage (a refusal throws) or readFirstPage (a refusal is empty, as fetchFirstPage was), signed-in reads go through authFetch, and useFeedCache's saveState takes the list. Notifications keeps the socket's arrivals as their own list merged at render, as Index does with recentDumps, and marks them read in one effect. PlaylistDetail (963 lines) only puts the pieces together (146): usePlaylist holds the playlist, its live sync and its edits, PlaylistHeader, PlaylistEditForm and PlaylistDumpList are one file each, and LiveDumpCard is the vote wiring DumpCardList and the playlist both use. What it re-invented is shared: the load is useFetchState, a dump going private and back is usePositionAwareSync, deletes and edits are useDumpListSync (which also keeps comment counts, which the page didn't). A removal is sent when its fade ends, or as the page is left, so an undo sends nothing: the removal/re-add/reorder dance, the pending-undo order and the 80 ms debounce of its echoes are gone. A refused reorder goes back to the server's last order and says so, instead of reloading the page. The comments written since the documentation pass broke its rules in places: module docs as a label and a colon ("The "dumps" tab of a profile: …"), noun-phrase fragments on types, fields and constants, stale lists of callers, over-long lines; they are sentences now, and the ones the refactor made wrong (PlaylistDetail as useFading's and FollowPlaylistButton's caller, "the profiles" as usePositionAwareSync's only users) say what is true. 650 frontend and 214 backend tests pass (new: usePagedList, useFetchState's initial, pageUrl/readPage, the deferred removal, a dump returning at its place in a playlist), and tsc, eslint, doc:lint, deno check, deno lint and deno fmt are clean.
All checks were successful
Build and Publish Docker Image / build-and-push (push) Successful in 49s
Build and Deploy Static Documentation Site / build-and-push (push) Successful in 22s

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
khannurien
2026-09-29 21:19:33 +00:00
parent 69d9bf899b
commit 07ac4bc629
81 changed files with 2016 additions and 2210 deletions

View File

@@ -17,25 +17,27 @@ import { fadeClassName, useFading } from "../feed/useFading.ts";
/** Passed to {@link useUpvotedList} by `UserUpvoted` and the profile. */
export interface UseUpvotedListOptions {
/** Whose upvotes the list holds, null while their profile loads. */
/**
* The list holds this user's upvotes. It is null while their profile loads.
*/
profileUserId: string | null;
/** Does nothing until the list is loaded. */
setItems: (fn: (prev: Dump[]) => Dump[]) => void;
/**
* Dumps already at hand, which a vote of the signed-in user on their own
* list puts first at once, before the socket's vote event. The profile
* passes its first page of the user's dumps.
* It holds dumps already at hand, which a vote of the signed-in user on
* their own list puts first at once, before the socket's vote event. The
* profile passes its first page of the user's dumps.
*/
source?: Dump[];
}
/** Returned by {@link useUpvotedList}. */
export interface UseUpvotedListResult {
/** For `DumpCardList`'s `cardClassName`. */
/** It goes to `DumpCardList`'s `cardClassName`. */
cardClassName: (dump: Dump) => string | undefined;
/**
* Whether the vote on dump `id` was withdrawn since the list loaded. The
* profile's `usePositionAwareSync` keeps such a dump from coming back.
* Checks whether the vote on dump `id` was withdrawn since the list loaded.
* The profile's `usePositionAwareSync` keeps such a dump from coming back.
*/
isWithdrawn: (id: string) => boolean;
}
@@ -87,9 +89,10 @@ export function useUpvotedList(
if (!isOwn) return;
const prev = prevMyVotesRef.current;
prevMyVotesRef.current = new Set(myVotes);
// Only a baseline: the list as loaded stands. myVotes may still be the
// empty set from before the socket's welcome (or the socket may never
// connect), and taking it as the truth here would hide every dump.
// This is only a baseline, and the list as loaded stands. myVotes may
// still be the empty set from before the socket's welcome (or the socket
// may never connect), and taking it as the truth here would hide every
// dump.
if (prev === null) return;
for (const id of prev) if (!myVotes.has(id)) withdraw(id);
const added = new Set([...myVotes].filter((id) => !prev.has(id)));